Skip to content

Conversation

@jaraco
Copy link
Member

@jaraco jaraco commented Sep 3, 2024

  • In sdist.prune_file_list, support build.build_base as a pathlib.Path.
  • Add test capturing missed expectation.
  • Enable the test
  • Add news fragment.

Merges incidental changes in distutils:

Summary of changes

Closes #4615

Pull Request Checklist

@jaraco jaraco requested a review from abravalheri September 3, 2024 13:32
Copy link
Contributor

@abravalheri abravalheri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much Jason!

@jaraco jaraco merged commit d8933c5 into main Sep 3, 2024
@jaraco jaraco deleted the bugfix/4615 branch September 3, 2024 23:01
@jaraco
Copy link
Member Author

jaraco commented Sep 4, 2024

These tests passed on pypy here, but failed on the release job (https://github.com/pypa/setuptools/actions/runs/10692324985).

@jaraco jaraco mentioned this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Some packages still needing setup.py fail to build in 74.0.0

3 participants